Skip to content

Tee audit fixes#226

Open
roger-bai-coinbase wants to merge 12 commits intomainfrom
tee-audit-fixes
Open

Tee audit fixes#226
roger-bai-coinbase wants to merge 12 commits intomainfrom
tee-audit-fixes

Conversation

@roger-bai-coinbase
Copy link
Contributor

TEE audit fixes (findings 2, 3, 5, 7, 8, 9, 10, 11)

Summary

Addresses security audit findings in NitroEnclaveVerifier by reducing contract surface area and tightening security properties.

Changes

  • Remove multi-version program ID sets (findings 3, 11): Drop EnumerableSet-backed _verifierIdSet/_aggregatorIdSet and all associated read/write functions. The contract now tracks only the single active program ID per coprocessor.
  • Remove NotImplemented error (finding 2): Eliminated placeholder error for disabled upstream functions.
  • Guard against FROZEN sentinel in addVerifyRoute (finding 8): Reject address(0xdead) with a new InvalidVerifierAddress error to prevent route map corruption.
  • Tighten timestamp bounds (findings 9, 10): Change </> to <=/>= so both edges of the validity window are exclusive.
  • Hardcode keccak256 length (finding 5) and document MAX_AGE allowance (finding 7).

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 25, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@roger-bai-coinbase roger-bai-coinbase marked this pull request as ready for review March 25, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants